All the suction cup things I’ve used all seem to fall off eventually.
Using the heater and AC to keep the windows clear works pretty well for me but even then I sometimes have to open a side window to help for a little while.
Another thing I’ve noticed is if you get in and out of the cab with snow on your boots that extra snow melting inside the cab adds to the fogging issue.