Bamaram,
You just had the roof redone. Any reason why a drip edge was not installed? Personally i don't like the "z" type bend and in your case could of been avoided.
This applies for both the the rake end and the eves. I am not a fan of going over old siding. Why was it not removed? Also when they did the roof did they replace the step flashing? Or did they reuse the old one? You just installed 30 yr plus products and if they reused the old aluminum step flash again thats something i would not of done. Just my 2 cents. The reason foam is used over your existing type of siding is to give them a flat surface for the new siding. Yes it does give you alittle extra insulation but its not the reason it is used. After looking at the pictures quickly looks like things are good. Again my question are just that. Not trying to say good or bad. Everyone has there own ways of doing things. I don't like covering up the old unless there is a good reason for it.