Hi armyret,
Just to give you some ideas, here's how I'm planning my pond.
My pond has a 2 foot tall, 12 foot wide levee around it. It's already covered with bermudagrass, which looks pretty and prevents erosion. Maximum water level will be 24" below the tops of the levee (ground level). My 10 acres are landscaped so that all runoff water is directed into the pond. The water will enter the pond at 1 choke point, which is a large limestone gravel filter bed. The water will percolate through the coarse gravel, run beneath the levee, and up into the pond. The filter bed is big enough so that partial stoppage won't stop the flow significantly.
If the pond level rises, the water will back up through the filter, and no fish can escape.
There is no need for an emergency spillway. Excessive water will simply run off without going into the pond. I would have to get a 1000 year flood to rise above the levee. If that happens, the pond would be the least of my worries.
Mistakes? Well... maybe my levees are a bit higher than necessary, but were a good place to dispose of the rich topsoil I have dug out. The levees are still settling, and I suspect will wind up at only 18" high or less
armyret, how many yards of soil did you remove from your pond? I need to move nearly 20,000 yards, and that's way too much for my tractor and FEL!