Yep, we've had both. When we lived in town, we had an upright in the kitchen right beside the refrigerator, so we had a frost free model just so my wife wouldn't have the work involved in defrosting periodically. I guess that would be my personal favorite if you aren't going to leave anything in there long enough to get freezer burn. Then when we bought the little farm, we got a chest type; not frost free (don't know whether anyone even makes a frost free in a chest type), and kept it in my shop building where there was lots of room. It's more efficient; you don't let the cold air slide out the bottom when you open the door, and they'll hold more simply because you can just pile it in there. Unfortunately, after a few years, it died, so we replaced it with an upright, not frost free, so stuff wouldn't be as likely to get freezer burn, and when it was time to defrost, we really didn't care if a little water got on the concrete floor out there.
So . . ., chest type more efficent and holds more for the same cubic foot rating, but it takes more floor space, harder to find things in the bottom, more trouble to defrost, and harder to move around if you ever need to move it. And my wife didn't like leaning over the edge of it to get things out of the bottom!
<font color=blue>which would you buy again?</font color=blue>
Upright, frost free.