I got it apart and had a good look at it. The splines on the coupler are totally sheared off clean. You can see them down farther inside the coupler but they should be out to the end all the way:
I have read all the comments, and thank you for the suggestions and compliments on the work. I made it this way so there would be no loose parts. The pump does slide right into the coupler as I carefully aligned it during final assembly but it is certainly possible to be off a fraction of a degree (actually likely in reality) and that may contribute to it. I am also thinking shock loading may be an issue.
There is not enough room for another Universal joint and I don't think that is the solution. A few of you mentioned a Lovejoy coupling and I had been thinking along those lines too. Unfortunately that leads to loose pieces that I could lose but it is all secured in place at the end so there is no longitudinal movement within the shaft that should cause the spider to fall out, so I think that is the way to go to deal with any slight misalignment and shock loading. Now I need to find one rated high enough that fits. I have 4.5" to the front of the bearing (the blue line), and a ~40-45ish hp PTO rating:
The pump shaft is a bit beaten up but should be fine. And no I won't weld on the pump shaft at all. I have found lovejoys with the same 13 tooth 7/8" spline, so I just need to find a 1.75" dia keyed half for the shaft or modify the shaft end, which may be very tricky to pull off.
A couple mentioned grease and I had put some grease into the coupler but it was just regular bearing grease. I think I will get some of the Moly paste and use that in Version 2.
Here is what the pump shaft looks like.
The only nagging question I have is if something in the hydraulic loop jammed and caused this to shear or if it was just shock loading or the like that lead to it. If there is something in the hydraulics that caused this, the new coupling may last 0.1 sec... I guess I will find out...